nodejs / nodejs.org

The Node.js® Website
https://nodejs.org
MIT License
6.14k stars 6.21k forks source link

[automated]: crowdin sync #6831

Closed nodejs-crowdin closed 3 months ago

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 12, 2024 10:12pm
github-actions[bot] commented 3 months ago
Lighthouse Results URL Performance Accessibility Best Practices SEO Report
/en 🟠 89 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗
bmuenzenmeyer commented 3 months ago

at first glance

✅ CI is green 🀔 there is a small diff throughout markdown files between en and other locales

image

I want to pull this locally to see if changes occur on the same format rule.

ovflowd commented 3 months ago

Worth also checking if enabling the languages locally they all render without issues.

For the initial PR it will definitely be painful as testing all these languages and pages is painful and time consuming, but definitely once we get this done it should become easier.

bmuenzenmeyer commented 3 months ago

I turned on french and spanish - we need crowdin to also create / translate locale.json files within https://github.com/nodejs/nodejs.org/tree/main/i18n/locales

Error: Cannot find module './fr.json'

I see the source defined correctly at https://github.com/nodejs/nodejs.org/blob/main/crowdin.yml#L33

I haven't looked on the crowdin side yet. I will try tomorrow.

bmuenzenmeyer commented 3 months ago

crowdin can see en.json and folks have been translating it. not sure why it isnt here. perhaps there is a rate limit? that'd be odd as it is broken in its current state

image

will reach out to crowdin

bmuenzenmeyer commented 3 months ago

@nodejs/web-infra @nodejs/nodejs-website

✅ CI is green ✅ local npm run format returns no changes

I'd like to merge this and then open a PR to enable fr - it's the only language 100% complete

image