nodejs / nodejs.org

The Node.js® Website

https://nodejs.org

MIT License

5.99k stars 6.15k forks source link

Closed bmuenzenmeyer closed 2 weeks ago

bmuenzenmeyer commented 2 weeks ago

Description

Enables fr locale! This is 100% translated and QA'd, and we think we've worked out the issues with the crowdin parser.

[ ] I have read the Contributing Guidelines and made commit messages that follow the guideline.
[ ] I have run npm run format to ensure the code follows the style guide.
[ ] I have run npm run test to check if all tests are passing.
[ ] I have run npx turbo build to check if the website builds without errors.
[ ] I've covered new added functionality with unit tests if necessary.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Jun 12, 2024 10:26pm

github-actions[bot] commented 2 weeks ago

Lighthouse Results URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 100	🟢 100	🟢 96	🟢 91	🔗
/en/about	🟢 99	🟢 100	🟢 96	🟢 91	🔗
/en/about/previous-releases	🟢 98	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 99	🟢 100	🟢 96	🟢 92	🔗

github-actions[bot] commented 2 weeks ago

Lines	Statements	Branches	Functions
	90.67% (593/654)	76.08% (175/230)	94.57% (122/129)

Tests	Skipped	Failures	Errors	Time
131	0 :zzz:	0 :x:	0 :fire:	5.183s :stopwatch:

bmuenzenmeyer commented 2 weeks ago

note - the real diff on this PR is only https://github.com/nodejs/nodejs.org/pull/6837/commits/96710a5d6969b9832b6c8cc134c4e26c99956f8e - the rest is a UI quirk of GitHub due to the target branch changing