nodejs / nodejs.org

The Node.js® Website
https://nodejs.org
MIT License
5.99k stars 6.15k forks source link

Add commitizen to repo to make it easy to follow conventional-commits #6844

Closed rikhall1515 closed 1 week ago

rikhall1515 commented 2 weeks ago

Description

This makes it so that you only need to run 'git commit' in order to get conventional-commit compliant commits.

Validation

Related Issues

Check List

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 18, 2024 8:16pm
rikhall1515 commented 2 weeks ago

This is a re-open of #6659 so I'm just currently waiting on this getting approved. Now this PR just has one single commit.

github-actions[bot] commented 2 weeks ago
Lighthouse Results URL Performance Accessibility Best Practices SEO Report
/en 🟠 86 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗
github-actions[bot] commented 2 weeks ago

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 :zzz: 0 :x: 0 :fire: 5.192s :stopwatch:
ovflowd commented 1 week ago

Thanks for your patience here and for iterating on this PR!

bmuenzenmeyer commented 1 week ago

The most critical workflow I want to ensure we don't change is the blog post release process. Has anyone tested that yet?

edit: Marco said this would not affect him

ovflowd commented 1 week ago

Alrighty, I believe we can merge this. If issues eventually rise, we can just revert and investigate :)