nodejs / nodejs.org

The Node.js® Website

https://nodejs.org

MIT License

5.99k stars 6.15k forks source link

fix: do not translate OpenJS trademark #6847

Closed bmuenzenmeyer closed 1 week ago

bmuenzenmeyer commented 2 weeks ago

Description

Per a Slack conversation and OpenJS Guidance - do not translate.

Validation

View the site in other locales

Related Issues

Check List

[x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
[x] I have run npm run format to ensure the code follows the style guide.
[x] I have run npm run test to check if all tests are passing.
[x] I have run npx turbo build to check if the website builds without errors.
[x] I've covered new added functionality with unit tests if necessary.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Jun 19, 2024 4:31am

github-actions[bot] commented 2 weeks ago

[!NOTE]\ Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. We recommend giving a read on our Translation Guidelines.

Thank you!

ovflowd commented 1 week ago

Fast Tracking this PR

github-actions[bot] commented 1 week ago

Lighthouse Results URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 98	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 99	🟢 100	🟢 100	🟢 92	🔗

github-actions[bot] commented 1 week ago

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.67% (593/654)	76.08% (175/230)	94.57% (122/129)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
131	0 :zzz:	0 :x:	0 :fire:	5.244s :stopwatch: