Open benjamingr opened 1 week ago
The latest updates on your projects. Learn more about Vercel for Git âïž
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
nodejs-org | â Ready (Inspect) | Visit Preview | Jun 19, 2024 1:17pm |
If I recall this document was a port of the original guide written many years ago, so not sure who even wrote this initially.
Lighthouse Results URL | Performance | Accessibility | Best Practices | SEO | Report |
---|---|---|---|---|---|
/en | ð¢ 97 | ð¢ 100 | ð¢ 100 | ð¢ 91 | ð |
/en/about | ð¢ 99 | ð¢ 100 | ð¢ 100 | ð¢ 91 | ð |
/en/about/previous-releases | ð¢ 99 | ð¢ 100 | ð¢ 100 | ð¢ 92 | ð |
/en/download | ð¢ 100 | ð¢ 100 | ð¢ 100 | ð¢ 91 | ð |
/en/blog | ð¢ 99 | ð¢ 100 | ð¢ 100 | ð¢ 92 | ð |
I wonder if there's a better way to describe this. What happens in Node.js currently is:
To emphasize that one can spawn threads from JS, maybe it's clearer to just mention Workers. But when we are talking about event loops, they do have a 1-1 correspondance with JS threads (each worker gets their own event loop). Or we can just drop "despite the fact that JavaScript is single-threaded" completely since it's not exactly clear what this is talking about in this context.
Honestly I appreciate the effort and don't have time to go over the whole thing but there are plenty of inaccuracies in this document.
This PR fixes the first one I noticed - JavaScript as a language is not single threaded. Nor has it ever been, and multithreaded JavaScript execution dates back at least 10-20 years
Description
Validation
Related Issues
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.