fix: Removed misleading info

nodejs / nodejs.org

The Node.js® Website

https://nodejs.org

MIT License

6.14k stars 6.21k forks source link

fix: Removed misleading info #6855

Closed Wellitsabhi closed 2 months ago

Wellitsabhi commented 3 months ago

Description

Removed the misleading info as mentioned in issue #6853

Validation

Related Issues

Fixes: #6853

Check List

[x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
[x] I have run npm run format to ensure the code follows the style guide.
[x] I have run npm run test to check if all tests are passing.
[x] I have run npx turbo build to check if the website builds without errors.
[x] I've covered new added functionality with unit tests if necessary.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Jul 7, 2024 4:29am

TenzDelek commented 3 months ago

@Wellitsabhi I think reverting the changes directly from the merged PR page will be a better choice for clarity and consistency rather than merging a new PR with a manual revert might create unnecessary changes.

Wellitsabhi commented 3 months ago

I agree but I don't have access to perform reverts, also @ovflowd might have put some thought before allowing to raise PR.

bmuenzenmeyer commented 3 months ago

I don't follow why this approach would be bad. Don't worry about it. Clean git history is overrated.

That said, we're not meeting anything until monorepo conversion stabilizes.

TenzDelek commented 3 months ago

I don't follow why this approach would be bad. Don't worry about it. Clean git history is overrated.

That said, we're not meeting anything until monorepo conversion stabilizes.

Can't agree more on this, :)

bmuenzenmeyer commented 2 months ago

This PR will need to be rebased or recreated now that https://github.com/nodejs/nodejs.org/pull/6850 merged.

Wellitsabhi commented 2 months ago

I really don't understand how it got closed, i shall be adding new PR again.

Wellitsabhi commented 2 months ago

@bmuenzenmeyer i recreated this PR as #6924 and would like to request review on it.