nodejs / nodejs.org

The Node.js® Website

https://nodejs.org

MIT License

5.99k stars 6.15k forks source link

Closed RafaelGSS closed 1 week ago

RafaelGSS commented 1 week ago

cc: @nodejs/tsc

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	❌ Failed (Inspect)		Jun 25, 2024 1:27pm

github-actions[bot] commented 1 week ago

Running Lighthouse audit...

github-actions[bot] commented 1 week ago

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.67% (593/654)	76.08% (175/230)	94.57% (122/129)

Tests	Skipped	Failures	Errors	Time
131	0 :zzz:	0 :x:	0 :fire:	5.527s :stopwatch:

ovflowd commented 1 week ago

FYI feel free to ignore the failed Vercel check.

But can we hold off the merge of this, until we get the monorepo stuff ready?

RafaelGSS commented 1 week ago

But can we hold off the merge of this, until we get the monorepo stuff ready?

How long would it take? This PR must land today.

bmuenzenmeyer commented 1 week ago

How long would it take? This PR must land today.

it's gonna be longer than that

RafaelGSS commented 1 week ago

So I'm afraid that will need to merge it now. Per policy we need to inform our users 7 days before the security release

ovflowd commented 1 week ago

You will need to do a forced merge as a TSC member since the main branch is locked right now.

RafaelGSS commented 1 week ago

Done