nodejs / nodejs.org

The Node.js® Website
https://nodejs.org
MIT License
6.14k stars 6.21k forks source link

chore(internationalization): Add Russian language to Home page #6866

Closed mirasayon closed 3 months ago

mirasayon commented 3 months ago

Description

Add Russian language to home page.

Validation

I dont know what is that. This is my first pull request 🤷‍♂️

Related Issues

Check List

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 27, 2024 3:00pm
mikeesto commented 3 months ago

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

mirasayon commented 3 months ago

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

What? I didn't want to wait for the moderators to take me there. And what about this PR. Well, I tried my best. Can't you just merge this? Then I will do it on the Crowdin platform.

ovflowd commented 3 months ago

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

What? I didn't want to wait for the moderators to take me there. And what about this PR. Well, I tried my best. Can't you just merge this? Then I will do it on the Crowdin platform.

No, we can't just merge this. There are processes for translating the website and certain triggers that are generated by Crowdin. Not to mention there are proofreaders who validate the translations.

Apologies for the wasted effort, but we have it written within the README the translation guidelines 👀 and a dedicated file named TRANSLATING.md

mirasayon commented 3 months ago

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

What? I didn't want to wait for the moderators to take me there. And what about this PR. Well, I tried my best. Can't you just merge this? Then I will do it on the Crowdin platform.

No, we can't just merge this. There are processes for translating the website and certain triggers that are generated by Crowdin. Not to mention there are proofreaders who validate the translations.

Apologies for the wasted effort, but we have it written within the README the translation guidelines 👀 and a dedicated file named TRANSLATING.md

Okay, okay. But bro, I’ve been waiting for 2 days already, I haven’t been accepted onto that platform yet. 🤷‍♂️

ovflowd commented 3 months ago

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

What? I didn't want to wait for the moderators to take me there. And what about this PR. Well, I tried my best. Can't you just merge this? Then I will do it on the Crowdin platform.

No, we can't just merge this. There are processes for translating the website and certain triggers that are generated by Crowdin. Not to mention there are proofreaders who validate the translations.

Apologies for the wasted effort, but we have it written within the README the translation guidelines 👀 and a dedicated file named TRANSLATING.md

Okay, okay. But bro, I’ve been waiting for 2 days already, I haven’t been accepted onto that platform yet. 🤷‍♂️

So you sent a request to be added there already? Let me check on that. Unfortunately we don't get notifications when someone requests to join.

mirasayon commented 3 months ago

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

What? I didn't want to wait for the moderators to take me there. And what about this PR. Well, I tried my best. Can't you just merge this? Then I will do it on the Crowdin platform.

No, we can't just merge this. There are processes for translating the website and certain triggers that are generated by Crowdin. Not to mention there are proofreaders who validate the translations.

Apologies for the wasted effort, but we have it written within the README the translation guidelines 👀 and a dedicated file named TRANSLATING.md

Okay, okay. But bro, I’ve been waiting for 2 days already, I haven’t been accepted onto that platform yet. 🤷‍♂️

So you sent a request to be added there already? Let me check on that. Unfortunately we don't get notifications when someone requests to join.

Yes. Ok

bmuenzenmeyer commented 3 months ago

sorry - i check crowdin nearly every day and missed those notifications coming in

mirasayon commented 3 months ago

sorry - i check crowdin nearly every day and missed those notifications coming in

No problem, bro, better tell me when my translation will be approved and Russian will be added to the pages.

bmuenzenmeyer commented 3 months ago

russian is 100% translated but requires proofreading. no crowdin members currently have that role - though one person expressed some interest in tag teaming it. can you help out with proofreading?

mirasayon commented 3 months ago

russian is 100% translated but requires proofreading. no crowdin members currently have that role - though one person expressed some interest in tag teaming it. can you help out with proofreading?

Yes, sure. But I can't check all the translations at once. Is it possible to do this step by step? And gradually add Russian to the pages, starting from the home page, and not all at once?