Description

In this pull request, I am solving the problem I figured out and reported on #6903 (now closed) and #6841 issue. It's a simple solution with a great visual impact on the issue, and finally, the solution works correctly on all idioms of the website.

Validation

Before	Now

Related Issues

Check List

[x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
[x] I have run npm run format to ensure the code follows the style guide.
[x] I have run npm run test to check if all tests are passing.
[x] I have run npx turbo build to check if the website builds without errors.
[x] I've covered new added functionality with unit tests if necessary.

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Jul 5, 2024 5:26am

nazarepiedady commented 3 days ago

@mikeal, @AugustinMauroy, could you do the honour of reviewing and merging this pull request, please?

nilkhankari commented 3 days ago

With these changes, the issue still occurs for viewport 1030.

ovflowd commented 3 days ago

With these changes, the issue still occurs for viewport 1030.

This is something else, not related to this issue. There's just literally no enough space to render things here.

github-actions[bot] commented 3 days ago

Lighthouse Results URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 98	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 100	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 99	🟢 100	🟢 100	🟢 92	🔗

github-actions[bot] commented 3 days ago

Unit Test Coverage Report

Unit Test Report

Tests	Skipped	Failures	Errors	Time
131	0 :zzz:	0 :x:	0 :fire:	5.194s :stopwatch:

nodejs / nodejs.org

fix: make the `searchButton` width dynamic to fit the content #6904