search

nodejs / performance

Node.js team focusing on performance
MIT License
371 stars 7 forks source link

OutgoingMessage.writeFile #135

Open ronag opened 7 months ago

ronag commented 7 months ago

I gave up on the PR due to all the asks for tests. Doesn't mean it's not a good idea in case someone with more patience wants to give it a go.

Would be even better if in the future it could be implemented natively.

https://github.com/nodejs/node/pull/50576

metcoder95 commented 7 months ago

The implementation is pretty good, I might make an effort to continue it. What testing exactly was asked for, beyond the permission system?

ronag commented 7 months ago

permissions, fd leaks, argument validators, ranges