search

nodejs / performance

Node.js team focusing on performance
MIT License
371 stars 7 forks source link

run compare on perf cores #162

Closed rluvaton closed 2 months ago

rluvaton commented 2 months ago

this should fix the issue with taskset in the compare CLI:

not configurable to avoid command injection possibility

After merging this, should revert the pr:

richardlau commented 2 months ago

not configurable to avoid command injection possibility

FWIW the script is currently specific to the Build infra as it uses the select-compiler.sh script, so hard coding the taskset parameter (for now) is reasonable. I'll leave it up to the performance team if they want this script to be runnable outside of the CI.

rluvaton commented 2 months ago

maybe we can close this if we merge