search

nodejs / postject

Easily inject arbitrary read-only resources into executable formats (Mach-O, PE, ELF) and use it at runtime.
Other
187 stars 14 forks source link

chore: add semantic commit check #29

Closed dsanders11 closed 2 years ago

dsanders11 commented 2 years ago

We've been using semantic commit messages for this project, let's enforce it.

RaisinTen commented 2 years ago

Actually, one more question - does this allow commits that start with [skip ci] like in https://github.com/postmanlabs/postject/pull/28?

dsanders11 commented 2 years ago

Actually, one more question - does this allow commits that start with [skip ci] like in https://github.com/postmanlabs/postject/pull/28?

I believe you would just need to put the [skip ci] somewhere else other than the start of the message, like on the end instead, which I think is preferable anyway since it keeps the starts of messages clean and easy to scan.

Actually looks like that's how the action author does it on their own commits: "chore: Release 4.6.0 [skip ci]"