search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

bundled dependencies #247

Closed calvinmetcalf closed 2 years ago

calvinmetcalf commented 8 years ago

we bundled our less common dependencies with version 2.2.0, but this immediately causes issues, specifically with yarn (yarnpkg/yarn#1774 and the tl;dr is that the issue was installing yarn not using yarn). The issue seemed to be about upgrading and the dependencies changing place. So we may need to come up with a different way to bundle them.

mcollina commented 8 years ago

IMHO we are in an impossible situation. It shouldn't matter about using bundledDependencies or not.

Anyway, we must bump the major if we want to try again, or have our own version of citgm.

calvinmetcalf commented 7 years ago

re citgm it was not fresh installs from what I could tell, just upgrades

On Tue, Nov 15, 2016 at 1:55 AM Matteo Collina notifications@github.com wrote:

IMHO we are in an impossible situation. It shouldn't matter about using bundledDependencies or not.

Anyway, we must bump the major if we want to try again, or have our own version of citgm.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nodejs/readable-stream/issues/247#issuecomment-260562353, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE4n8F70FOjfi164cHTx-nD3c06U1Tiks5q-VdXgaJpZM4KxpbJ .

mcollina commented 7 years ago

Ahum. Looks like it's an npm bug in computing the tree. Sigh. Whenever we bump the major, it will be a nice change to add.