search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

destroy/pump #283

Closed calvinmetcalf closed 6 years ago

calvinmetcalf commented 7 years ago

since pump relies on destroy, we probably want destroy in before we do pump.

mcollina commented 7 years ago

I would say so, let's wait for https://github.com/nodejs/node/pull/12925 to land.

mcollina commented 7 years ago

Relevant issues:

https://github.com/mafintosh/pump/issues/17 https://github.com/nodejs/node/issues/1834

calvinmetcalf commented 7 years ago

I have a pull I've started a bit back that I can clean up with a bit and submit it, I was waiting on destroy to land first

mcollina commented 7 years ago

@calvinmetcalf I think you can fire that, and we can discuss it in the issue tracker.

calvinmetcalf commented 7 years ago

yeah I need to clean it up, I had been waiting on destroy to land

On Tue, Jun 6, 2017 at 9:58 AM Matteo Collina notifications@github.com wrote:

@calvinmetcalf https://github.com/calvinmetcalf I think you can fire that, and we can discuss it in the issue tracker.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/nodejs/readable-stream/issues/283#issuecomment-306494459, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE4n1-uE1K8qRsvleCxb2ITQBA_umypks5sBVr6gaJpZM4NT_qE .

calvinmetcalf commented 7 years ago

nodejs/node#13506

SimenB commented 7 years ago

Any news here? Or is it blocked on landing in node core? Would love to be able to just depend on readable stream 🙂

mcollina commented 7 years ago

@SimenB it's just work that needs doing. Do you want to help a bit?

SimenB commented 7 years ago

My understanding of stream internals are next to none, so I'm unfortunately not much help with that 🙁

prog1dev commented 6 years ago

https://github.com/nodejs/node/pull/12925 landed in Version 8.0.0, 2017-05-30