search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

Node 8 #290

Closed calvinmetcalf closed 7 years ago

calvinmetcalf commented 7 years ago

ok I need to fix the Stream._isUint8Array and similar stuff

mcollina commented 7 years ago

There is a PR waiting to me merged for this.

cc @addaleax for the other things

calvinmetcalf commented 7 years ago

I know how to add them I just didn't get around to it before I went home

On Fri, Jun 9, 2017, 4:43 PM Matteo Collina notifications@github.com wrote:

There is a PR waiting to me merged for this.

cc @addaleax https://github.com/addaleax for the other things

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nodejs/readable-stream/pull/290#issuecomment-307494906, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE4n9xWKmm3F2rOsgOkrZJfYjdITrfQks5sCa58gaJpZM4N1xEg .

calvinmetcalf commented 7 years ago

and we are green (though I need to rebase it on top of the other pull)

mcollina commented 7 years ago

@calvinmetcalf I've added #255 commit in here. It should be good to go.

calvinmetcalf commented 7 years ago

ok bumped it so it should hopfully build

mcollina commented 7 years ago

I think we should release it as 2.3.0. Let's do this next week, so that @nodejs/streams might have time to review it (I would also be at home and not traveling, in case we need to last-minute bugfixes)

calvinmetcalf commented 7 years ago

ok sounds good

addaleax commented 7 years ago

I looked over the patch and nothing seemed to stick out … I might not have time for a full review but this seems fine to me.

addaleax commented 7 years ago

We might want to include something like https://github.com/nodejs/node/pull/13760.

mcollina commented 7 years ago

I think we should wait for that to be released

calvinmetcalf commented 7 years ago

ok I'll plan on publishing this soon