Selectively use Object.defineProperty if it is available.

nodejs / readable-stream

Node-core streams for userland

https://nodejs.org/api/stream.html

Other

1.03k stars 227 forks source link

Selectively use Object.defineProperty if it is available. #303

Closed mcollina closed 7 years ago

mcollina commented 7 years ago

Do not merge, as it missing #298.

@ScottFreeCode can you confirm this is working for you?

Fixes #301

mcollina commented 7 years ago

I will update when 8.1.3 comes out.

ScottFreeCode commented 7 years ago

Tried pulling this in by using "nodejs/readable-stream#maybe-ie7-ie8" as "readable-stream"; seems to have fixed IE 7, but we've still got some issue with IE 8 and it's not showing the line number from the original file (or even which file was the original); let me talk to the team lead about getting access to some kind of cache or artifact upload of the browser bundle so we can try to determine what that line is...