search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

Update isArray please to 2.x #318

Closed Croydon closed 6 years ago

Croydon commented 6 years ago

Please update isArray to 2.x

Dependencies checks are kinda annoying us with deprecated warnings right now 🙈

mcollina commented 6 years ago

I would reccomend to fine-tune your checks, there is very little need to check this module.

I would see if we can update this dependency, but all the code that is there is fine.

Croydon commented 6 years ago

I just noticed this: https://github.com/nodejs/readable-stream/commit/66aa1ca5b635305cfc6fc518149be8034a78fe9c

Depending on which Node.js versions you want to support the dependecy might not be required anymore.

mcollina commented 6 years ago

version 2 is deprecated. The actual path is removing the dependency, and we will do this in the next major because v2 still support old versions of Node and Browsers that do not have Array.isArray().