search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

process-nextick-args used incorrectly #323

Closed kolodny closed 6 years ago

kolodny commented 6 years ago

process-nextick-args was modified to make the nextTick property a "live" binding. In https://github.com/nodejs/readable-stream/commit/41a330137ce9cda5a95ef23d5454c70acb9c962a#diff-279988bef5e6fbf7ed82cae28ecc2d59L128 this was changed to keep a reference to a potentially stale function. I'm not sure how to go about changing the generated code to make this change, else I would just make a PR.

mcollina commented 6 years ago

You need to fix it in this block: https://github.com/nodejs/readable-stream/blob/master/build/files.js#L127-L136. Then cd build; npm i; node build.js 8.9.4. Should do the trick.

If you could also add a test, it would be awesome. Place it under https://github.com/nodejs/readable-stream/tree/master/test/ours.

mcollina commented 6 years ago

Fixed in 2.3.5