search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

Restore browser tests #339

Closed vweevers closed 6 years ago

vweevers commented 6 years ago

Over at Airtap (airtap/airtap#171) we have been wondering which browsers readable-stream will target, if and when browser tests are restored. Specifically whether IE9 and IE10 support is still required?

I can do a PR to setup airtap, unless you want to wait for a stable release (airtap/airtap#170).

@mcollina /cc @feross @ralphtheninja

mcollina commented 6 years ago

I have been working on readable-stream@3 at https://github.com/nodejs/readable-stream/commits/next. I do not have all tests passing yet.

It would be fantastic to have airtap supported there, and I think won't need IE9 and IE10 support there anyway.

Would you like to send a PR against that? The 2.x line should support IE9 and IE10, even thought we are not really testing them at this point.

vweevers commented 6 years ago

Would you like to send a PR against that?

Sure! I noticed you removed the matrix from .travis.yml (e9cde33830a2ee06311f4a7b03d0656720301e4b). Do you want me to wait until the tests are passing in node?

mcollina commented 6 years ago

@vweevers feel free to re-add the matrix for the browser things. We will not be supporting ancient Node anymore.

vweevers commented 6 years ago

Opera 11 (fd1efbf49d562b293df6cece8167733aee9cc768) is also pretty old, and the version range 11..latest is huge. Perhaps the target should be -3..latest like the other evergreen browsers?

vweevers commented 6 years ago

It would be fantastic to have airtap supported there, and I think won't need IE9 and IE10 support there anyway.

cc @jhiesey because you said you want IE9/10 in stream-http which depends on readable-stream.

mcollina commented 6 years ago

@vweevers +1 of having the same range.

vweevers commented 6 years ago

340