search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

readable-stream@3 #344

Closed mcollina closed 6 years ago

mcollina commented 6 years ago

As titled, this is a port of Node.js 10.5.0. It includes all the semver-major changes of both Node 9 and 10.

Fixes #283 Fixes #284 Fixes #212 Fixes #297 Fixes #346 Fixes #339 Fixed #335

mcollina commented 6 years ago

I've just released readable-stream@3.0.0-rc.1. Install it with npm i readable-stream@next and report bugs!

phated commented 6 years ago

On node 8.11.1, readable-stream crashes the process with Error: Cannot find module 'babel-runtime/core-js/symbol'

Do we really need that? Why would it not be included?

phated commented 6 years ago

working in my small test now

calvinmetcalf commented 6 years ago

we probably want a changelog or a notice in the readme about what breaking changes are in v3 to make upgrading easier, otherwise LGTM

mcollina commented 6 years ago

@calvinmetcalf done.