search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

3.0.0-rc.2: stream-browserify failing to resolve require statements #350

Closed taj-codaio closed 6 years ago

taj-codaio commented 6 years ago

Not sure if stream-browserify needs changing or if readable.js needs changing.

ERROR in ./node_modules/stream-browserify/index.js
Module not found: Error: Can't resolve 'readable-stream/duplex.js' in '/Users/timjim/code/experimental/node_modules/stream-browserify'
 @ ./node_modules/stream-browserify/index.js 30:16-52
 @ ./node_modules/papaparse/papaparse.js
 @ ./modules/browser/integrations/private/csv_import.ts
 @ ./modules/browser/integrations/import_csv_dialog.ts
 @ ./modules/browser/navigation/dialog_manager.ts
 @ ./modules/browser/navigation/index.ts
 @ ./modules/browser/app/private/document_container.ts
 @ ./modules/browser/app/private/routes.ts
 @ ./modules/browser/app/private/app.ts
 @ ./modules/browser/app/start_app.ts
 @ ./modules/browser/app/index.ts
 @ ./modules/browser/app/entrypoint.js

ERROR in ./node_modules/stream-browserify/index.js
Module not found: Error: Can't resolve 'readable-stream/passthrough.js' in '/Users/timjim/code/experimental/node_modules/stream-browserify'
 @ ./node_modules/stream-browserify/index.js 32:21-62
 @ ./node_modules/papaparse/papaparse.js
 @ ./modules/browser/integrations/private/csv_import.ts
 @ ./modules/browser/integrations/import_csv_dialog.ts
 @ ./modules/browser/navigation/dialog_manager.ts
 @ ./modules/browser/navigation/index.ts
 @ ./modules/browser/app/private/document_container.ts
 @ ./modules/browser/app/private/routes.ts
 @ ./modules/browser/app/private/app.ts
 @ ./modules/browser/app/start_app.ts
 @ ./modules/browser/app/index.ts
 @ ./modules/browser/app/entrypoint.js

ERROR in ./node_modules/stream-browserify/index.js
Module not found: Error: Can't resolve 'readable-stream/transform.js' in '/Users/timjim/code/experimental/node_modules/stream-browserify'
 @ ./node_modules/stream-browserify/index.js 31:19-58
 @ ./node_modules/papaparse/papaparse.js
 @ ./modules/browser/integrations/private/csv_import.ts
 @ ./modules/browser/integrations/import_csv_dialog.ts
 @ ./modules/browser/navigation/dialog_manager.ts
 @ ./modules/browser/navigation/index.ts
 @ ./modules/browser/app/private/document_container.ts
 @ ./modules/browser/app/private/routes.ts
 @ ./modules/browser/app/private/app.ts
 @ ./modules/browser/app/start_app.ts
 @ ./modules/browser/app/index.ts
 @ ./modules/browser/app/entrypoint.js

ERROR in ./node_modules/stream-browserify/index.js
Module not found: Error: Can't resolve 'readable-stream/writable.js' in '/Users/timjim/code/experimental/node_modules/stream-browserify'
 @ ./node_modules/stream-browserify/index.js 29:18-56
 @ ./node_modules/papaparse/papaparse.js
 @ ./modules/browser/integrations/private/csv_import.ts
 @ ./modules/browser/integrations/import_csv_dialog.ts
 @ ./modules/browser/navigation/dialog_manager.ts
 @ ./modules/browser/navigation/index.ts
 @ ./modules/browser/app/private/document_container.ts
 @ ./modules/browser/app/private/routes.ts
 @ ./modules/browser/app/private/app.ts
 @ ./modules/browser/app/start_app.ts
 @ ./modules/browser/app/index.ts
 @ ./modules/browser/app/entrypoint.js
mcollina commented 6 years ago

I have removed those. They gave no net benefit if not complicating the code, and in the end they ended un requiring the main file anyway. You should require(‘readable-stream’) instead.

taj-codaio commented 6 years ago

Thanks - I'll see if I can patch stream-browserify.