search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

Move to Buffer.from() #358

Closed gabrielschulhof closed 5 years ago

gabrielschulhof commented 6 years ago

new Buffer(...) is being used in a bunch of places even though it's deprecated. Can we move to Buffer.from(...) in those places?

mcollina commented 6 years ago

Those are just browsers tests. So, yes we should move to Buffer.from() and it's not even a semver-minor change. Would you like to send a PR?

gabrielschulhof commented 6 years ago

Can do.

On Tue, Aug 28, 2018 at 11:19 AM, Matteo Collina notifications@github.com wrote:

Those are just browsers tests. So, yes we should move to Buffer.from() and it's not even a semver-minor change. Would you like to send a PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nodejs/readable-stream/issues/358#issuecomment-416627244, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7k0VERGDjUU02WDezDth5ZTqK8hsMKks5uVV-ZgaJpZM4WP1O4 .

gabrielschulhof commented 5 years ago

I guess this landed in 32c1045 so it can be closed, right?