search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

remove Buffer constructor usage (#358) #359

Closed gabrielschulhof closed 6 years ago

gabrielschulhof commented 6 years ago
gabrielschulhof commented 6 years ago

@mcollina IIUC I have removed the block.

gabrielschulhof commented 6 years ago

Can do.

On Thu, Aug 30, 2018 at 8:12 AM, Matteo Collina notifications@github.com wrote:

@mcollina commented on this pull request.

In examples/CAPSLOCKTYPER.JS https://github.com/nodejs/readable-stream/pull/359#discussion_r214005813 :

@@ -11,7 +11,7 @@ function MyStream () { inherits(MyStream, Transform);

MyStream.prototype._transform = function (chunk, outputFn, callback) {

  • outputFn(new Buffer(String(chunk).toUpperCase()));
  • outputFn(Buffer.alloc(String(chunk).toUpperCase()));

@gabrielschulhof https://github.com/gabrielschulhof would you mind sending a follow-up PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/readable-stream/pull/359#discussion_r214005813, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7k0THDwg4ZxZq_TtJvet2Fyztmt2lBks5uV9aggaJpZM4WSDXb .