search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

Add node >= 6 to package.json #362

Closed dougwilson closed 6 years ago

dougwilson commented 6 years ago

Hi ! I noticed that in 3.x

v3.x.x of readable-stream supports Node 6, 8, and 10, ...

I added this to the package.json so automated tools that determine this requirement.

mcollina commented 6 years ago

Thanks!

dougwilson commented 6 years ago

Thanks! But why did my email change in the commit? Can my private email be removed from master, please? I would like to use the email set on the commit in my PR if possible. Thanks!

mcollina commented 6 years ago

I just hit the the "squash and merge button". You should probably remove your private email from Github. Which email do you want to use? I cannot easily see what you used in that commit.

dougwilson commented 6 years ago

This is my commit: https://github.com/nodejs/readable-stream/commit/08f6c1162be23e0f2eb624a22cfe053241639f11.patch

I'm not sure what you mean by remove it from github. My somethingdoug.com email is on github.

mcollina commented 6 years ago

I did not know what was your private email, and it was automatically used by Github when using the "squash" button. So, github knows your private email and tends to use it for these things. If you do not want it to appear in a commit, you should change your github configuration.

dougwilson commented 6 years ago

Ah, I see. I will email github support and stop using github for the time being to see what is going on. Thanks for that info for what you did, I will pass that along!

Anyway, hopefully that patch link works for you. Otherwise it's just the email listed on my github profile that I want to use :+1:

mcollina commented 6 years ago

I've just amended the commit and force-pushed. Please check.

dougwilson commented 6 years ago

Looks good. Sorry for the trouble of what should have been a simple PR 😕