search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

Symbol is undefined in IE11 #364

Closed jhiesey closed 6 years ago

jhiesey commented 6 years ago

In IE11, I get

SCRIPT5009: 'Symbol' is undefined

The error is coming from https://github.com/nodejs/readable-stream/blob/bbc3ddcc6dcab2c2f7b9db7aaad22d9c979e2a56/lib/_stream_readable.js#L944

mcollina commented 6 years ago

Thanks for reporting this. Would you have time to send a PR for this?

jhiesey commented 6 years ago

@mcollina would you say the appropriate solution would be to feature test Symbol and just not define asyncIterator if it's not available?

mafintosh commented 6 years ago

Yea that sounds like a good approach to me

On Mon, Sep 24, 2018, 18:58 John Hiesey notifications@github.com wrote:

@mcollina https://github.com/mcollina would you say the appropriate solution would be to feature test Symbol and just not define asyncIterator if it's not available?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nodejs/readable-stream/issues/364#issuecomment-424139542, or mute the thread https://github.com/notifications/unsubscribe-auth/AAW_VTH-4p1fqHuz1a-4Lr1fcGcZMtCqks5ueVWOgaJpZM4W3hjO .

jhiesey commented 6 years ago

OK, so once that's fixed there's a second issue here: https://github.com/nodejs/readable-stream/blob/e890201f99f448c97d3d0bab36c403d8d3f30407/lib/_stream_readable.js#L357

SCRIPT438: Object doesn't support property or method 'isNaN'
jhiesey commented 6 years ago

Thanks!