search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

add missing exports for browsers #409

Closed angelo-v closed 5 years ago

angelo-v commented 5 years ago

This PR adds the missing exports, mentioned in https://github.com/nodejs/readable-stream/issues/408

There should be tests, that would have catched the problem beforehand, but I did not figure out how to add those in reasonable time. I appreciate, if someone more experienced with this project adds those tests.

mcollina commented 5 years ago

Can you add/port a couple of test to our browser suite https://github.com/nodejs/readable-stream/tree/master/test/browser? As an example: https://github.com/nodejs/readable-stream/blob/master/test/parallel/test-stream-pipeline.js and https://github.com/nodejs/readable-stream/blob/master/test/parallel/test-stream-finished.js.

angelo-v commented 5 years ago

I tried to do that, but failed. Cannot invest more time on that, sorry

angelo-v commented 5 years ago

Anyone else that could do it? Would be cool to have this merged.