Check for existence of `process` object (fix for v3)

nodejs / readable-stream

Node-core streams for userland

https://nodejs.org/api/stream.html

Other

1.03k stars 227 forks source link

Closed th0r closed 2 years ago

th0r commented 5 years ago

Fixes #412 for v3

Notes:

Library was built using the following command: ./build/build.js 10.15.3
Some unrelated files were changed because of the updated Babel version (updated runtime helpers)

mcollina commented 5 years ago

Can you please enable me to push on this PR? I have the test fixed.

th0r commented 5 years ago

@mcollina I've added you as collaborator to the forked repo if this is what you are asking for.

th0r commented 5 years ago

@mcollina any updates?

vweevers commented 5 years ago

I'm -1 on the nextTick change.

Maintaining a polyfill as inline code is painful
This change, intended for webpack users, will also affect browserify users. I would prefer that webpack 5 users include node-libs-browser in their configuration to get webpack 4 behavior.
I'm worried that having a separate nextTick queue will introduce subtle, hard-to-debug race issues.