search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

Upgrade airtap and use GitHub Actions #443

Closed vweevers closed 4 years ago

vweevers commented 4 years ago

Complements #418.

vweevers commented 4 years ago

Travis fails on npm install because playwright (which has an install script) requires node 10. I'll remove playwright for now, unless someone has an idea for a workaround.

mcollina commented 4 years ago

They keys are set up

vweevers commented 4 years ago

Build failed:

Error: 23 Sep 19:50:19 - Sauce Connect could not establish a connection.

Will see if I can replicate that on another repo that has an almost identical setup, and no sauce connect problems.

vweevers commented 4 years ago

With debug output enabled, the problem seems to be the credentials:

ERROR: connecting to https://saucelabs.com/rest/v1/***/tunnels: HTTP response code indicated failure, reply: {"message": "Not authorized"}.
ERROR: can't reach https://saucelabs.com/rest/v1/***/tunnels, please check your username/access key, firewall and proxy settings.

@mcollina Could you please double-check the credentials? You can also try it locally:

SAUCE_USERNAME=xx SAUCE_ACCESS_KEY=xx DEBUG=airtap* npm run test-browsers

# Run a diagnostic test
SAUCE_USERNAME=xx SAUCE_ACCESS_KEY=xx ./node_modules/sauce-connect-launcher/sc/sc-4.6.2-linux/bin/sc --doctor
mcollina commented 4 years ago

Thanks! Fixed and now the tests are passing!

mcollina commented 4 years ago

Running npm test-browser I'm getting:

Hostname 'airtap.local' must resolve to 127.0.0.1. Please add an entry to your hosts file.
vweevers commented 4 years ago

@mcollina That hostname error is expected. Some browsers don't route localhost traffic through the Sauce Connect tunnel. To work around that, airtap uses a custom hostname that defaults to airtap.local and should resolve to 127.0.0.1. Only needed for sauce, not for playwright and others.

The debug steps I added in the last commit should be removed, especially ./node_modules/sauce-connect-launcher/sc/sc-4.6.2-linux/bin/sc which will break when a new Sauce Connect version is released by Sauce Labs.

mcollina commented 4 years ago

oh gosh... can you send a fresh PR?