nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

Use pkgjs/action for CI to auto-upgrade to latest nodes #469

Open dominykas opened 2 years ago

dominykas commented 2 years ago

The CI workflow used here is almost identical to a standard Node.js library testing pattern (checkout, npm install, npm test).

As part of Package Maintenance WG, I've recently created pkgjs/action - it basically does that standard Node testing pattern, but it automatically maintains the test matrix for you, i.e. it will automatically detect the lowest supported (major) version from engines field and will automatically add new Node.js versions as they come out.

As the action is pretty new, I'd like to get some battle testing for it.

Would people mind if I opened a PR to start using it here? I'm willing to take on the maintenance of that until we feel it's stable.

The end result here would probably look something like this: https://github.com/pkgjs/action/blob/main/.github/workflows/ci.yaml

tony-go commented 2 years ago

Could definitely help on this one ☝🏼.