search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

Improve playwright harness #475

Closed mcollina closed 2 years ago

mcollina commented 2 years ago

Currently:

  1. it is not installing in any of my machines, the download get stuck forever
  2. npm install get stuck and does not complete on CI (ref https://github.com/microsoft/playwright/issues/14853)

I think we should:

@ShogunPanda could you take a look?

vweevers commented 2 years ago

I'm curious why airtap wasn't a good fit? That's off-topic - I'd welcome feedback in an airtap/playwright issue.

mcollina commented 2 years ago

The fundamental problem was Sauce Labs, not airtap. Definitely @ShogunPanda could provide more details.

Ideally if we could run only on Github Actions it would be great but... it's not really working as expected right now.

benjamingr commented 2 years ago

@pavelfeldman

vweevers commented 2 years ago

The playwright connection issue also reproduces for me, but randomly, so hopefully it's just a temporary backend issue.

sijakret commented 2 years ago

also facing this issue. i am assuming this is an issue with the resource serving the browser packages right?

ShogunPanda commented 2 years ago

@vweevers That's exactly the problem with airtap - I started by removing Sauce Labs and then I had problem on configuring playwright in this project and some other debugging issues on the WebSocket server. I don't recall exactly what (long time has passed, sorry) so I chose to brew a quick and dirty custom one.

ShogunPanda commented 2 years ago

@mcollina I'll go for a separate package.json as you suggested.

mxschmitt commented 2 years ago

@mcollina it seems like a temporary outage on Azure side. I'll discuss it with the team later to provide fallback CDN endpoints to prevent that for the future. See here for the Azure Front Door outage.

mcollina commented 2 years ago

thanks!

mcollina commented 2 years ago

I think the outage resolved.