Lazily require abort-controller

[hildjj]

It throws when it has been bundled, then loaded in node.

How I found this:

• Updating dependencies in cbor
• In the cbor-web sub-package, I use webpack to pre-bundle cbor for easy use in the browser
• I then spot-check that webpack'd version in node to ensure that it works as expected
• This error: TypeError: Cannot destructure property 'AbortController'
• Tracked it back to code in abort-controller, which should only get used in the browser, but because I'm running a bundle, I hit it in node
• Backtracked into readable-stream. There's no reason to require abort-controller unless globalThis.AbortController doesn't exist
• Moving the require after the globalThis.AbortController check fixes my issue

This is probably an edge case that I hope nobody else runs into, but the fix for my problem shouldn't hurt anyone else.

[hildjj]

It looks like your Browsers / Browsers (macos-latest, firefox, webpack) test may have a timing issue. I saw a failure of that test in my fork that went away when I re-ran that test.

[mcollina]

Could you do the changes in the build script and re-run them?

Take a look at https://github.com/nodejs/readable-stream/blob/main/build/replacements.mjs.

[hildjj]

Things I didn't fix (yet) because they aren't germane to the issue at hand:

• Your build script appears to be using a bad URL template for node versions. (https://nodejs.org/v18.0.0/node-v18.0.0.tar.gz instead of https://nodejs.org/dist/v18.0.0/node-v18.0.0.tar.gz)
• I tried using v18.5, but that broke a bunch of your tests, so I ran this against node v18.0.0
• Whitespace and semi-colon consistency changes introduced by the scripts. I decided to leave what the script did, which I hope was correct.
• Existing lint issues with src/errors.js

[mcollina]

Good work!