nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 227 forks source link

build npm script seems to be broken #483

Closed cjihrig closed 2 years ago

cjihrig commented 2 years ago

npm run build 18.8.0 does not seem to work. It fails with the following message:

[INFO] Downloading https://nodejs.org/v18.8.0/node-v18.8.0.tar.gz ...
[INFO] Downloading failed with HTTP code 404.

This failure also seems to remove the test files, so subsequent npm test runs fail.

Is the build script still intended to be used? If so, it seems like dist/ is missing from the download URL.

vweevers commented 2 years ago

Is the build script still intended to be used?

Yes. This is a bug. The old build script did have /dist:

https://github.com/nodejs/readable-stream/blob/97fd94f404709542a7d69b271eddfcc34345916e/build/build.js#L25

Needs a fix here:

https://github.com/nodejs/readable-stream/blob/77e0378b1a8a46c42fc3fce43969b83abf69ca36/build/build.mjs#L138

cjihrig commented 2 years ago

Opened https://github.com/nodejs/readable-stream/pull/484