search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 225 forks source link

Problems caused by using ES2021（lib/internal/validators.js ） #492

Closed Martin-CF closed 1 year ago

Martin-CF commented 1 year ago

reason： Our project uses coap, and then coap depends on readable-stream. Found after searching： lib/internal/validators.js use ES2021 causes our project to fail to run normally。 line-140 const max = 4_294_967_295， It is suggested to change it to const max = 4294967295

tony-go commented 1 year ago

Hey @Martin-CF 👋

Thanks for reporting this issue.

Could you please provide us with a reproducible example? (like a gist)

tony-go commented 1 year ago

Maybe duplicate of https://github.com/nodejs/readable-stream/pull/491/files ?

Martin-CF commented 1 year ago

https://github.com/nodejs/readable-stream/pull/490/commits/e3258fff13d87ca154137d2919f09693596d3fda#diff-84047e9de2de28fd3ae796466cebdbae912d724504cb1b44c4f45b3517c1fa5f Line 140, const max = 4_294_967_295