search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 225 forks source link

fix: use workaround loading process-shim for browserify #497

Closed bergos closed 1 year ago

bergos commented 1 year ago

replaced require('process') with require('process/') to fix #496

The build step generated quite a big diff. I compared a few samples with the code in the https://github.com/nodejs/node repository, and the generated code looks good to me. I think there was a problem earlier on.

@mcollina Hints on how to solve this are very welcome. Is there a post-process step? Should I create a separate PR just for the diff generated by the build and then fix the process-shim issue?

vweevers commented 1 year ago

The build step generated quite a big diff.

Also happened on #491. Safe to ignore: https://github.com/nodejs/readable-stream/pull/491#issuecomment-1317251199. Although it might be preferable to open a separate PR that only does a rebuild; then these two PRs will be cleaner.

bergos commented 1 year ago

@mcollina I've updated the PR. The diff is now much smaller and more readable.