nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 225 forks source link

Today I used [patch-package](https://github.com/ds300/patch-package) to patch `readable-stream@3.6.0` for the project I'm working on. #503

Closed jingledongding closed 1 year ago

jingledongding commented 1 year ago

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch readable-stream@3.6.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/readable-stream/lib/internal/streams/stream-browser.js b/node_modules/readable-stream/lib/internal/streams/stream-browser.js
index 9332a3f..dd024fc 100644
--- a/node_modules/readable-stream/lib/internal/streams/stream-browser.js
+++ b/node_modules/readable-stream/lib/internal/streams/stream-browser.js
@@ -1 +1 @@
-module.exports = require('events').EventEmitter;
+module.exports = require('react-native-events').EventEmitter;

This issue body was partially generated by patch-package.

mcollina commented 1 year ago

What should we do about this?

benjamingr commented 1 year ago

You should keep your local patch if you want to ussse react-native-events' EventEmitter.

This doesn't belong in readable-stream itself.