chore: don't polyfill stream in webpack.browser.config.mjs

nodejs / readable-stream

Node-core streams for userland

https://nodejs.org/api/stream.html

Other

1.03k stars 225 forks source link

Closed jeswr closed 1 year ago

jeswr commented 1 year ago

This PR does 2 things:

Cleans up the existing webpack browser config by removing alias' and plugins that are no longer required.
Tests for regression in #516 by adding a new webpack config to import what is effectively the file import * as all from 'readable-stream'

jeswr commented 1 year ago

Was expecting Webpacking to fail with this change. Will investigate by Monday at the latest.

jeswr commented 1 year ago

Should be ready to go now @mcollina (I don't have permissions to mark you as a reviewer so pinging you instead).

The CI for Webpacking is failing (as expected), and should pass again once #516 is solved.

mcollina commented 1 year ago

I thought it was a simple fix, but it's actually harder than the time I currently have available to fix it. @jeswr would you mind to identify a fix?

@ShogunPanda could you take a look as well?

jeswr commented 1 year ago

Unfortunately I'm quite time poor myself at present @mcollina, so it is unlikely I will have a chance in the next 2 weeks to look into it.

If the issue hasn't been fixed after that - or if I find time beforehand - then I'll take a look.