search

nodejs / readable-stream

Node-core streams for userland
https://nodejs.org/api/stream.html
Other
1.03k stars 225 forks source link

fix: don't require `stream` package in codebase #520

Closed jeswr closed 1 year ago

jeswr commented 1 year ago

Closes #516.

Supercedes #517 and #519.

This replaces require('stream') with require('../../lib/stream.js') in the build script so that the stream module is never imported.

Since #517 I've moved the regression test to a new folder in the root since the other test fixtures are being copied from the nodejs codebase; wheras the one I add is specific to readable-stream.

jeswr commented 1 year ago

Bump @vweevers @benjamingr

vweevers commented 1 year ago

I don't have time to review.

jeswr commented 1 year ago

@mcollina it doesn't look like the others have time to review so can this be released?

rubensworks commented 1 year ago

Would it be possible to merge this package? Many of our downstream users are running into issues because of this

Happy to help where possible!