nodejs / release-cloudflare-worker

Infra for serving Node.js downloads and documentation.
https://nodejs.org/dist
MIT License
23 stars 7 forks source link

use biomejs instead of prettier and eslint #132

Closed AugustinMauroy closed 2 months ago

AugustinMauroy commented 3 months ago

On this project we have two tools to format and lint our code. But they're not the best performers.

One solution is to use biomejs which is a trainer and linter of code written in rust. It covers what prettier and eslint do on this project.

In addition the dev node_module size will be reduce:

flakey5 commented 3 months ago

Are there plans to switch the website and api docs repos to biomejs as well?

flakey5 commented 3 months ago

I think we should be using as many of the same tools across projects that we can just to make switching between them as easy as possible.

I'd be in favor of using it here as a trial run though if we're looking at using it in the website and api docs repos

AugustinMauroy commented 3 months ago

Honestly, I saw that Amaro was using Biome, so I thought that was cool. I then looked at comparisons (dep size, performance, compatibility, etc.), which is why I'm offering it on this repo. Yes api-doc-tooling could also use biome.

But for nodejs.org, I have already looked it is not possible it still lacks support for markdown by biome. But yes if not for nodejs.org we could use biome instead of Eslint, prettier and styleLint.

As you say, there should be uniformity in the tools we use. So here's a list of repo's that could also receive biome

[!NOTE] On nodejs org we have a lintting team that we can ping

flakey5 commented 3 months ago

cc @nodejs/web-infra wdyt?

flakey5 commented 3 months ago

So here's a list of repo's that could also receive biome

I think their usage should be discussed in other issues with the teams that maintain them since they don't fall under the website scope of things

ovflowd commented 3 months ago

cc @nodejs/web-infra wdyt?

+1

flakey5 commented 2 months ago

Think we can move forward with this then

bmuenzenmeyer commented 2 months ago

I was going to mention that this feels like chasing "the new-thing"...and it felt oddly reminiscent to how rome was supposed to take off, and then I discovered that its the same people/project.

I'm ambivalent - but also wanted to mention that eslint is an OpenJS Foundation project.

AugustinMauroy commented 2 months ago

Brian is right on this point.

Maybe we could get an opinion from TSC or team lint?

ovflowd commented 2 months ago

Brian is right on this point.

Maybe we could get an opinion from TSC or team lint?

I don't think the TSC would wage in here. It's not up to them. It's not a Node technical decision.

I'm fine staying with ESlint too. Let's keep it as it is for the meantime, as things are working, and revisit this in the future, wdyt @flakey5?

flakey5 commented 2 months ago

I'm fine staying with ESlint too

+1

ovflowd commented 2 months ago

I'll close this for the time being then.