search

nodejs / release-cloudflare-worker

Infra for serving Node.js downloads and documentation.
https://nodejs.org/dist
MIT License
22 stars 5 forks source link

refactor: code cleanup and handlebars template #30

Closed ovflowd closed 1 year ago

ovflowd commented 1 year ago

This PR does some code cleanup (standard conventions, code readability, adds todo statements and does minor code stylistic updates, renamed some files)

This PR introduces handlebars for the template engine for the directory listing

This PR updates some of the packages.

ovflowd commented 1 year ago

FYI @MoLow this is giving 5XX errors, but I have no idea why...

ovflowd commented 1 year ago

@MoLow could you test this locally with npm run start why it is failing?

jbergstroem commented 1 year ago

@MoLow could you test this locally with npm run start why it is failing?

Without testing locally, my guess would be that handlebars generates code which is not allowed in cloudflare workers.

ovflowd commented 1 year ago

@MoLow could you test this locally with npm run start why it is failing?

Without testing locally, my guess would be that handlebars generates code which is not allowed in cloudflare workers.

Indeed. I didn't know that eval is not allowed within CF Worker context