nodejs / release-cloudflare-worker

Infra for serving Node.js downloads and documentation.
https://nodejs.org/dist
MIT License
22 stars 5 forks source link

src: automatically rewrite latests and docs links #39

Closed MoLow closed 1 year ago

MoLow commented 1 year ago

Fixes https://github.com/nodejs/release-cloudflare-worker/issues/33

flakey5 commented 1 year ago

I think it looks good but I'd appreciate it if we could reach a consensus on how we'd like to do the rewrites, either in the worker as done in this pr or via Cloudflare rules like @jbergstroem suggested. Cloudflare rules might overlap with the Terraform changes happening now so I'd be in favor of merging this pr and then later on if we think there's benefits in using the Cloudflare rules (e.g. better perf, less worker cpu time, whatever) we can explore it more