search

nodejs / release-cloudflare-worker

Infra for serving Node.js downloads and documentation.
https://nodejs.org/dist
MIT License
22 stars 5 forks source link

latest-v20.x shows two releases #50

Closed richardlau closed 11 months ago

richardlau commented 11 months ago

https://r2.nodejs.org/download/release/latest-v20.x/ shows both Node.js 20.7.0 and 20.8.0: image

AFAICT the other latest-* links only have one release as expected.

flakey5 commented 11 months ago

@MoLow do you know if the symlink paths are still being uploaded to the R2 bucket as separate folders? If so then that's probably what happened here, The last deploy to prod was a week ago so not sure if your redirect change is live or not

flakey5 commented 11 months ago

Hmmm staging seems to show the same and the redirect change is definitely on there. image

/download/release/latest-v20.x/ should be grabbing nodejs/release/v20.8.0 from the bucket. Going to https://r2.nodejs.org/dist/v20.8.0/ only shows the v20.8 release, so the versions are still in their own separate directories. I definitely think for whatever reason it's still trying to hit nodejs/release/latest-v20.x on the bucket even though it really shouldn't be, will test locally to see what I can find

edit: yeah that's what is happening image