nodejs / release-cloudflare-worker

Infra for serving Node.js downloads and documentation.
https://nodejs.org/dist
MIT License
22 stars 5 forks source link

Automatically merge & deploy prs for updating redirect links #66

Closed flakey5 closed 10 months ago

flakey5 commented 10 months ago

Prs such as #57 are automatically generated by the Update Links action. That is the action that makes sure links such as nodejs.org/docs/latest/ point to the absolute latest documentation available.

As of now, the action can either be triggered manually by someone with write access to the repository or by waiting until midnight. This poses a problem since when a release is promoted it needs to be available as immediately as possible. Releasers don't have write access to this repo, and so they can't manually trigger the action. Furthermore, only members of @nodejs/web-infra can approve and merge the pr. Then, someone with write access needs to trigger the Deploy action to get the updated redirects into prod.

This of course isn't great. nodejs/node#50710 is partially fixing this problem by triggering the Update Links action whenever there's a new Github release of node, however there still is the pr that needs to be approved and merged by someone on the @nodejs/web-infra team and it still needs to be manually deployed to prod.

Solution: