search

nodejs / release-cloudflare-worker

Infra for serving Node.js downloads and documentation.
https://nodejs.org/dist
MIT License
22 stars 5 forks source link

https://nodejs.org/download/release/index.* not updated for Node 21.2.0 #72

Open Conduitry opened 10 months ago

Conduitry commented 10 months ago

URL:

https://nodejs.org/download/release/

Browser Name:

n/a

Browser Version:

n/a

Operating System:

n/a

How to reproduce the issue:

The https://nodejs.org/download/release/index.json and https://nodejs.org/download/release/index.tab files were not updated to include Node 21.2.0 that was released earlier today.

I do note that https://nodejs.org/dist/index.json and https://nodejs.org/dist/index.tab were updated.

Is this a bug in the release process? Are the old URLs deprecated and should they redirect to the /dist/ ones?

Should I update scripts that are currently using https://nodejs.org/download/release/index.tab to use https://nodejs.org/dist/index.tab instead?

ovflowd commented 10 months ago

Too many assumptions here, but fair process of thought. No, nothing is wrong; We're making some tests in our infrastructure and switching traffic from our DigitalOcean server to Cloudflare R2 + Cloudflare Workers.

The /download/ path was being served by R2 whilst /dist is still being served by DO. We changed /download for the time being to be served once again by DO until we fix some of the current issues.

You can see the progress on https://github.com/nodejs/release-cloudflare-worker

ovflowd commented 10 months ago

Also, kinda worrying that these paths were not updated, but I'm assuming that we have an issue where for some reason the promote script didn't promote them.

@targos is there any log from the promote script execution you can provide? @flakey5 asked if the upload_to_cloudflare.sh was called or not 🤔

targos commented 10 months ago

There were no relevant logs.

richardlau commented 10 months ago

@flakey5 asked if the upload_to_cloudflare.sh was called or not 🤔

It must have been called for the release assets to have been uploaded to R2, right?

targos commented 10 months ago

I manually synced the assets after seeing that they were not on R2

targos commented 10 months ago

I don't know if the upload script was called, but it isn't commented out in _promote.sh: CleanShot 2023-11-15 at 14 49 02

ovflowd commented 10 months ago

I don't know if the upload script was called, but it isn't commented out in _promote.sh: CleanShot 2023-11-15 at 14 49 02

Not even sure if this logic is correct. @MoLow was the one that initially implemented it, right?

MoLow commented 10 months ago

yes, it seems correct.

ovflowd commented 10 months ago

Can we simulate this script for v21.2.0 to see what it does? (what are the args that it passes?)

MoLow commented 10 months ago

this seems to have been updated