fix: caching - Githubissues

nodejs / release-cloudflare-worker

Infra for serving Node.js downloads and documentation.

https://nodejs.org/dist

MIT License

22 stars 5 forks source link

Closed flakey5 closed 10 months ago

flakey5 commented 10 months ago

See #73

[x] Explicit caching strategies (@MattIPv4 's comment)
[x] Only cache 2XX responses, and if they're get Requests (explicit cache) (already true)
[x] Our default responses (on the constants) should have explicit headers for no-cache/no-store
[x] 5XX responses also should not have cache (already true)
[x] We should extract many other implicit constants ... to proper constant files

flakey5 commented 10 months ago

Quick question, do we need to also add CACHE_HEADERS.failure to our 5XX responses? (the try/catch on the worker.ts?)

That is also a part of this pr

ovflowd commented 10 months ago

Quick question, do we need to also add CACHE_HEADERS.failure to our 5XX responses? (the try/catch on the worker.ts?)

That is also a part of this pr

Oh I somehow didnt see this, still not seeing it 🤔 can you point me to the diff?

flakey5 commented 10 months ago

Oh I somehow didnt see this, still not seeing it 🤔 can you point me to the diff?