Closed joyeecheung closed 5 years ago
I just updated the entries above to split them into three sections.
1) Flaky tests 2) Build related failures 3) Linter failures
@nodejs/trace-events PTAL at: parallel/test-trace-event-promises
and parallel/test-trace-events-fs-sync
@nodejs/http @nodejs/http2 PTAL at: parallel/test-http-chunk-problem
, parallel/test-http2-pipe
and sequential/test-benchmark-net
@nodejs/fs PTAL at: parallel/test-fs-readfilesync-pipe-large
and parallel/test-fs-syncwritestream
@nodejs/workers PTAL at: parallel/test-worker-dns-terminate
@nodejs/modules PTAL at: parallel/test-module-loading-globalpaths
@nodejs/build-infra PTAL at the jenkins issues.
I think parallel/test-worker-dns-terminate
needs a stress test. It should be fixed based on https://github.com/nodejs/node/issues/21327#issuecomment-411577291 and this PR https://github.com/nodejs/node/pull/22189 no longer fails after rebase and this one https://github.com/nodejs/node/pull/22198 fails but doesn't have a fix in it.
Local --repeat 1920 on linux box have also passed just fine.
@BridgeAR By the way I think if the failure is caused by the --worker
job (most test-packetnet-ubuntu1604-x64-2
failures there), it probably needs help from @nodejs/workers instead - and most of them are actually ENOENT
under --worker
so it could have something to do with how tmpdir
resolves there.
Closing because..there is no reason to keep it open?
By the way the --worker
test failures reduced significantly these two days. I'll post the new results grabbed today.
Produced with
ncu-ci walk pr --stats
, counting tests that failed more than 1 PRPotential flaky tests:
Build failures:
Linter failures (likely not a flaky, if not a build flake):