search

nodejs / repl

REPL rewrite for Node.js ✨🐢🚀✨
MIT License
177 stars 25 forks source link

feat : Support for multiline statements #16

Closed antsmartian closed 6 years ago

antsmartian commented 6 years ago

Hello,

Added the supported for multiline statements :https://github.com/nodejs/repl/issues/15

I have tested locally, it works.

Thoughts please?

Note: Recoverable.js is something I had taken from node core.

antsmartian commented 6 years ago

@devsnek : Hey.. Have updated the PR with review comments fixed. Let me know if it's all good :) I played around and seems to be working fine:

screen shot 2018-07-26 at 6 32 33 pm
antsmartian commented 6 years ago

@devsnek Thanks, I have done those changes locally, but somehow, I missed to push it. Now I guess it should be alright.

Thanks for your time on this.

devsnek commented 6 years ago

ping @TimothyGu

antsmartian commented 6 years ago

Just now realized my git username was wrong in commits; so just rewritten my commit message with right user name.

antsmartian commented 6 years ago

Done with the Symbol changes. cc @jdalton @devsnek

Thanks for your time.

antsmartian commented 6 years ago

@devsnek Taken care, thanks. Let me know if anything needed from my side.

antsmartian commented 6 years ago

@devsnek Any update on this? I'm waiting for your reply :)