search

nodejs / repl

REPL rewrite for Node.js ✨🐢🚀✨
MIT License
179 stars 25 forks source link

feat: Initial test case for repl errors #17

Open antsmartian opened 6 years ago

antsmartian commented 6 years ago

Hey @devsnek

I worked on the item : https://github.com/nodejs/repl/issues/6

This should be the beginning for adding test cases for repl 👍

Have a look and let me know we can follow the same pattern for other test cases too. Once this is good, may be we can then add scripts to run our tests on our npm build process.

Thanks for your time on this.

antsmartian commented 6 years ago

@devsnek Thanks for your help. I have refactored the assertion accordingly. Let me know if anything needs to be done further.

antsmartian commented 6 years ago

ping @devsnek

antsmartian commented 6 years ago

ping @devsnek

devsnek commented 6 years ago

i'd like to see if we can set up CI of some sort for the linter before we merge more PRs

antsmartian commented 6 years ago

@devsnek Perfect! Sounds good to me.

antsmartian commented 6 years ago

@devsnek Any update on this?

antsmartian commented 4 years ago

I know it's a long time, any update here? cc @devsnek