search

nodejs / repl

REPL rewrite for Node.js ✨🐢🚀✨
MIT License
177 stars 25 forks source link

Error stacktrace is not getting printed properly #18

Closed antsmartian closed 5 years ago

antsmartian commented 6 years ago

Hello,

I guess with this commit : https://github.com/nodejs/repl/commit/e06c75c8788c90b056c85d743cebea087d0cc98c

Error stacktrace is missing outside repl context too. For example, when I was working on this PR : https://github.com/nodejs/repl/pull/17

I noticed when assertions failed, the stack trace was missing. I saw only the below:

assert.js:269
    throw err;
    ^

AssertionError [ERR_ASSERTION]: should throw syntax error
    at
devsnek commented 5 years ago

This was fixed in https://github.com/nodejs/repl/commit/f4f203e23a57c7ccf8c0dee703a1e14c983e1480