search

nodejs / string_decoder

'string_decoder' module from Node.js core
Other
32 stars 20 forks source link

publish new version #1

Closed calvinmetcalf closed 7 years ago

calvinmetcalf commented 7 years ago

so we don't have 2 versions of safe-buffer with readable-stream

mcollina commented 7 years ago

I've added you to npm repo, so you can do a release.

calvinmetcalf commented 7 years ago

is it ok the tests don't pass curently

mcollina commented 7 years ago

they were when I released Il giorno gio 22 giu 2017 alle 20:12 Calvin Metcalf < notifications@github.com> ha scritto:

is it ok the tests don't pass curently

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/nodejs/string_decoder/issues/1#issuecomment-310459520, or mute the thread https://github.com/notifications/unsubscribe-auth/AADL46j3ee88p-Y-FbKUxnn1560PG1P_ks5sGq6MgaJpZM4OCgrE .

calvinmetcalf commented 7 years ago

hm will look into this

On Thu, Jun 22, 2017 at 2:15 PM Matteo Collina notifications@github.com wrote:

they were when I released Il giorno gio 22 giu 2017 alle 20:12 Calvin Metcalf < notifications@github.com> ha scritto:

is it ok the tests don't pass curently

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub < https://github.com/nodejs/string_decoder/issues/1#issuecomment-310459520>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AADL46j3ee88p-Y-FbKUxnn1560PG1P_ks5sGq6MgaJpZM4OCgrE

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nodejs/string_decoder/issues/1#issuecomment-310460275, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE4n9papK3i532Duj_DqVhdMtRLad8wks5sGq8-gaJpZM4OCgrE .

calvinmetcalf commented 7 years ago

ah they pass in node 6 but not 8, this goes for our version of string decoder and the one in node, so this isn't a regression persay so I'll publish it

On Thu, Jun 22, 2017 at 2:27 PM Calvin Metcalf calvin.metcalf@gmail.com wrote:

hm will look into this

On Thu, Jun 22, 2017 at 2:15 PM Matteo Collina notifications@github.com wrote:

they were when I released Il giorno gio 22 giu 2017 alle 20:12 Calvin Metcalf < notifications@github.com> ha scritto:

is it ok the tests don't pass curently

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub < https://github.com/nodejs/string_decoder/issues/1#issuecomment-310459520 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AADL46j3ee88p-Y-FbKUxnn1560PG1P_ks5sGq6MgaJpZM4OCgrE

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nodejs/string_decoder/issues/1#issuecomment-310460275, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE4n9papK3i532Duj_DqVhdMtRLad8wks5sGq8-gaJpZM4OCgrE .