search

nodejs / string_decoder

'string_decoder' module from Node.js core
Other
32 stars 20 forks source link

Updated to Node 8.1.2 #3

Closed mcollina closed 6 years ago

mcollina commented 7 years ago

@addaleax Can you have a look while this fails in Node < 8?

cc @calvinmetcalf

calvinmetcalf commented 7 years ago

it's actually the current one too that fails in node 8

mcollina commented 7 years ago

the current one fails on node >= 8, while this one fails on Node < 8

calvinmetcalf commented 7 years ago

ah, confusing breaking change of some sort

mcollina commented 7 years ago

So, I think it might be related to something low level, and we need to abstract the test.

mcollina commented 7 years ago

I think this the source of the problem: https://github.com/nodejs/node/commit/24ef1e67757514db9ee1aeded555d4fb336ca817

I think we should just conditionally pick the right test depending on the version of V8 we running against.

mcollina commented 7 years ago

I have disabled the V8-dependant checks.

mcollina commented 6 years ago

Closed in favor of #6